fix: semgrep installation + runtime arguments now work #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viega
previously approved these changes
Nov 11, 2023
src/configs/sastconfig.c4m
Outdated
| func find_semgrep(ignore) { | ||
| result := find_exe("semgrep", []) | ||
| semgrep_path := "/tmp/semgrep.env/bin/semgrep" | ||
| result := find_exe(semgrep_path, []) |
There was a problem hiding this comment.
find_exe() IIRC searches the $PATH too, even if you call it with a full path. I don't know why we'd prioritize looking in /tmp if it's already installed on the system??
I guess if we don't like the version installed?
There was a problem hiding this comment.
mixed up the argument order here which should be fixed now, but yes we want to ensure we have the right version
| return true | ||
|
|
||
| trace("semgrep could not be installed") | ||
| return false | ||
| } | ||
|
|
||
| func get_semgrep_args(artifact) { |
There was a problem hiding this comment.
Since we're touching this stuff should we make it more configurable? Tho I guess a semgrep component might be better for that?
There was a problem hiding this comment.
I think a separate pr for that would be best
miki725
reviewed
Nov 12, 2023
viega
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
closes #92
Description
find_semgrepso semgrep can be found even if it's not in $PATHonto work withconfig=autoTesting
tests need to be added to ensure that semgrep run returns correct sast json: #95