Jtv/releaseitems #67
Merged
Jtv/releaseitems #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult seems better than assuming a URL.
…off the 'hint' messages for stuff we want to keep around
…nal IP associated w/ the host portably. Used it in the reporting server to make it not be hacky, and added PUBLIC_IPV4_ADDR_WHEN_CHALKED and _OP_PUBLIC_IPV4_ADDR.
… much for good intros to the product.
miki725
reviewed
Oct 19, 2023
Dockerfile
Outdated
| @@ -1,88 +1,3 @@ | |||
| FROM ghcr.io/crashappsec/nim:ubuntu-2.0.0 as nim | |||
There was a problem hiding this comment.
seems like accidental overwrite?
| getCurrentException().getStackTrace() | ||
| publish("debug", msg) | ||
| let | ||
| msg = "" # "Handling exception (msg = " & getCurrentExceptionMsg() & ")\n" |
There was a problem hiding this comment.
msg empty on purpose? should the commented out code be removed?
As chalk exec would parse the full command, if it had any arguments chalk was not familiar with, chalk would not parse it correctly and therefore will call command incorrectly. By adding -- after the command name, chalk ignores rest of the args and passes them as-is to the command. For example this now works: ``` ENTRYPOINT ["ls", "-la"] ``` As chalk will end up calling it as: ``` /chalk exec --exec-command-name=ls -- -la ```
|
fixes #70 |
miki725
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chalkdust.ioand made some minor changes / fixes due to the experience.