feat(api): add OIDC refresh token support to chalk #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viega
approved these changes
Oct 11, 2023
|
Yeah let me see what is going on. I will hold off merging either PR until I know what the resolution needs to be. |
|
#52 resolved so squash-mergiung this to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#50
Description
Added OIDC refresh token support to chalk to allow transparent exchange of refresh token for a new access token when it has expired.
Testing
Running
chalk --trace setupwill exercise the code pathway to authenticate and get issued a new access token and refresh token. The dev instance of the secret-manager and it's authentication service have been set to have access token lifetimes of 60 seconds to aid in testing.