fix: dockerfile ENTRYPOINT wrapping #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker has a few edge cases how ENTRYPOINT can be provided which broke chalk wrapping. * simply `ENTRYPOINT` was not handled correctly and was resulting in segfault * `ENTRYPOINT [""]` was attempting to wrap `""` which is invalid All these variants are handled now: * `ENTRYPOINT` * `ENTRYPOINT []` * `ENTRYPOINT [""]` In addition explicitly invalid commands are ignored and wrapping is disabled. This way chalk does not yield and error but the runtime is bound to fail. * `ENTRYPOINT [" "]` * `ENTRYPOINT ["", ""]
ee7
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif necessaryIssue
segfaults in some cases and invalid wrapping in others
Description
docker has a few edge cases how ENTRYPOINT can be provided which broke chalk wrapping.
ENTRYPOINTwas not handled correctly and was resulting in segfaultENTRYPOINT [""]was attempting to wrap""which is invalidAll these variants are handled now:
ENTRYPOINTENTRYPOINT []ENTRYPOINT [""]In addition explicitly invalid commands are ignored and wrapping is disabled. This way chalk does not yield and error but the runtime is bound to fail.
ENTRYPOINT [" "]ENTRYPOINT ["", ""]Testing