fix: _OP_ERRORS was missing plugin logs #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the key was collected by `system` plugin which is executed first it was missing any of the logs which were reported after that point. Moved its collection to `metsys` plugin which is executed last which should ensure all relevant logs are included.
ee7
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif necessaryIssue
_OP_ERRORShad some logs missingDescription
As the key was collected by
systemplugin which is executed first it was missing any of the logs which were reported after that point. Moved its collection tometsysplugin which is executed last which should ensure all relevant logs are included.Testing
set
chalk_log_leveltotracelocally and observe log output