-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only wrapping ENTRYPOINT, if present #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miki725
force-pushed
the
ms/cmd
branch
2 times, most recently
from
December 27, 2023 17:37
8270b06
to
df62496
Compare
previously we were wrapping either CMD/ENTRYPOINT however that is incorrect behavior as it can change semantics of the image if the base image has any custom ENTRYPOINT For example official AWS lambda images have this problem and their ENTRYPOINT requires specific CMD shape and therefore we cannot adjust CMD without guaranteeing container behavior does not change.
In some cases chalk can run for uid which does not have a home directory such as in AWS lambda in which case chalk fails to resolve all paths which have ~ in them. This fixes that by ignoring those paths when resolvePath fails and in some other cases like for temp files also checks that tmp folder is writable.
this now includes all task containers metadata as well as stats (if present)
this allows to prioritize some sinks higher in the reporting order
miki725
force-pushed
the
ms/cmd
branch
6 times, most recently
from
January 3, 2024 18:54
f3ea90f
to
fba1ec4
Compare
otherwise we get `HUP` signal handling indicating there is an error which is incorrect as HUP is sent as part of TTY handling logic
limiting first year to 2023, even though some files were committed in 2022
this allows tests not be exclusive as otherwise there are conflicts between tests
at chalk time image is not built yet so we cannot run external tools on it yet
viega
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Discussed comments off-line, and have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
images with custom ENTRYPOINT from base image would break such as default AWS lambda images
Description
Previously we were wrapping either CMD/ENTRYPOINT however that is incorrect behavior as it can change semantics of the image if the base image has any custom ENTRYPOINT
For example official AWS lambda images have this problem and their ENTRYPOINT requires specific CMD shape
and therefore we cannot adjust CMD without guaranteeing container behavior does not change.
In addition PR includes:
_AWS_REGION
resolvePath
can actually resolve which is not true in lambda for example which resulted in segfaults. the reason is that lambda runs with user993
, not default container user which and as that user does not have home path anything which resolves~
blows uppriority
field to sink configs to allow to prioritize some sinks higher in the processing orderTesting
Requires/TODOs