fix: checking chalk permissions on self-extract #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miki725
force-pushed
the
ms/presign
branch
2 times, most recently
from
45aff8a to
f8254f9
Compare
When chalk binary has only execute permission: ``` $ ls -la chalk -rwx--x--x 1 root sudo 10114504 Dec 5 00:27 chalk ``` Chalk binary can execute however during self-extract it will be unable to read itself therefore would be unable to load embedded config and chalk proceeds running with default configs which is incorrect. This adds a check during self-extract which ensures chalk has read permission on itself.
miki725
force-pushed
the
ms/readpermission
branch
from
64e705e to
ae2f14d
Compare
viega
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When chalk binary has only execute permission:
Chalk binary can execute however during self-extract it will be unable to read itself therefore would be unable to load embedded config and chalk proceeds running with default configs which is incorrect. This adds a check during self-extract which ensures chalk has read permission on itself.
Testing
found this issue while using github action