Support for Electrolux EACM EZ/N3 #2131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aLupus/IRremoteESP8266 into feature/electrolux-ac-eacm
fix: checksum
fix: checksum
… feature/electrolux-ac-eacm # Conflicts: # src/ir_Electrolux.h
StellaLupus
force-pushed
the
feature/electrolux-ac-eacm
branch
2 times, most recently
from
9151129
to
9f5d1fd
Compare
NiKiZe
reviewed
Aug 10, 2024
StellaLupus
force-pushed
the
feature/electrolux-ac-eacm
branch
5 times, most recently
from
ecccc3a
to
9092a5b
Compare
fix: code cleanup and formatting fix: test build
StellaLupus
force-pushed
the
feature/electrolux-ac-eacm
branch
from
3acbf90
to
a9e750c
Compare
|
This is great work, it seems you have also started on tests? We will want to have at least one raw dump from original remote, to create test for it. (Something that we could help with if you want since it isn't always the easiest) |
Yes, I started working with tests, but my PC on Windows and I have problems with local run. electrolux_decode.xlsx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the ir remote COR508R for AC Electrolux EACM EZ/N3.
Includes support for decode and encode data from remote
Checksum implemented worked.
No tests yet