Skip to content

Commit

Permalink
Little fix
Browse files Browse the repository at this point in the history
  • Loading branch information
cranktakular committed May 30, 2024
1 parent 228c3ba commit 91d4b24
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions exchanges/coinbasepro/coinbasepro_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -394,16 +394,9 @@ func TestMovePortfolioFunds(t *testing.T) {
if len(portID) < 2 {
t.Skip(skipInsufficientPortfolios)
}
// TODO: The API's set up so that the funds on a portfolio can only be checked one portfolio at a time,
// so studiously checking for a valid portfolio to send funds from would take ages. And so, this aims to
// fail gracefully if there's not enough funds. However, as of this week, the exchange returns a 429 header,
// indicating the rate limit was hit when it wasn't, and so prompting GCT to keep ramming its head into it
// until something gives and it fails badly. I think either they'll need to fix that, we'll need to waste
// a bunch of time to fail gracefully, or we'll have to rewrite some core retry policy stuff to deal with
// cases like this.
_, err = c.MovePortfolioFunds(context.Background(), testCrypto.String(), portID[0].UUID, portID[1].UUID,
testAmount)
if err != nil && err.Error() != errPortTransferInsufFunds {
if err != nil {
t.Error(err)
}
}
Expand Down

0 comments on commit 91d4b24

Please sign in to comment.