Merge master, resolving conflict

.github/workflows/proto-lint.yml

@@ -16,14 +16,12 @@ jobs:
 
       - name: Setup build depends
         run: |
-         go get github.com/grpc-ecosystem/grpc-gateway/v2/internal/[email protected]
-         go get google.golang.org/grpc/cmd/protoc-gen-go-grpc
-         go install github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway
-         go install github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2
-         go install google.golang.org/protobuf/cmd/protoc-gen-go
-         go install google.golang.org/grpc/cmd/protoc-gen-go-grpc
-
-      - uses: bufbuild/[email protected]
+          go install github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway@latest
+          go install github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2@latest
+          go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
+          go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest
+
+      - uses: bufbuild/[email protected]
 
       - name: buf generate
         working-directory: ./gctrpc

backtester/btcli/main.go

@@ -59,7 +59,7 @@ func setupClient(c *cli.Context) (*grpc.ClientConn, context.CancelFunc, error) {
 
 	var cancel context.CancelFunc
 	c.Context, cancel = context.WithTimeout(c.Context, timeout)
-	conn, err := grpc.DialContext(c.Context, host, opts...)
+	conn, err := grpc.NewClient(host, opts...)
 	return conn, cancel, err
 }
 

backtester/engine/live.go

@@ -398,9 +398,7 @@ func (d *dataChecker) FetchLatestData() (bool, error) {
 	if !d.hasUpdatedFunding {
 		err = d.UpdateFunding(false)
 		if err != nil {
-			if err != nil {
-				log.Errorln(common.LiveStrategy, err)
-			}
+			log.Errorln(common.LiveStrategy, err)
 		}
 	}
 

backtester/engine/setup.go

@@ -145,14 +145,16 @@ func (bt *BackTest) SetupFromConfig(cfg *config.Config, templatePath, output str
 				if err != nil {
 					return err
 				}
-				exch.SetDefaults()
-				exchBase := exch.GetBase()
-				exchBase.Verbose = cfg.DataSettings.VerboseExchangeRequests
+
 				var dc *gctconfig.Exchange
-				dc, err = exch.GetDefaultConfig(context.TODO())
+				dc, err = gctexchange.GetDefaultConfig(context.TODO(), exch)
 				if err != nil {
 					return err
 				}
+
+				exchBase := exch.GetBase()
+				exchBase.Verbose = cfg.DataSettings.VerboseExchangeRequests
+
 				err = exch.Setup(dc)
 				if err != nil {
 					return err

cmd/config_builder/builder.go

@@ -36,7 +36,7 @@ func main() {
 	cfgs := make([]config.Exchange, 0, len(exchanges))
 	for x := range exchanges {
 		var cfg *config.Exchange
-		cfg, err = exchanges[x].GetDefaultConfig(context.Background())
+		cfg, err = exchange.GetDefaultConfig(context.Background(), exchanges[x])
 		if err != nil {
 			log.Printf("Failed to get exchanges default config. Err: %s", err)
 			continue

cmd/exchange_template/wrapper_file.tmpl

@@ -26,25 +26,6 @@ import (
 	"github.com/thrasher-corp/gocryptotrader/portfolio/withdraw"
 )
 
-// GetDefaultConfig returns a default exchange config
-func ({{.Variable}} *{{.CapitalName}}) GetDefaultConfig(ctx context.Context) (*config.Exchange, error) {
-	{{.Variable}}.SetDefaults()
-	exchCfg := new(config.Exchange)
-	exchCfg.Name = {{.Variable}}.Name
-	exchCfg.HTTPTimeout = exchange.DefaultHTTPTimeout
-	exchCfg.BaseCurrencies = {{.Variable}}.BaseCurrencies
-
-	{{.Variable}}.SetupDefaults(exchCfg)
-
-	if {{.Variable}}.Features.Supports.RESTCapabilities.AutoPairUpdates {
-		err := {{.Variable}}.UpdateTradablePairs(ctx, true)
-		if err != nil {
-			return nil, err
-		}
-	}
-	return exchCfg, nil
-}
-
 // SetDefaults sets the basic defaults for {{.CapitalName}}
 func ({{.Variable}} *{{.CapitalName}}) SetDefaults() {
 	{{.Variable}}.Name = "{{.CapitalName}}"

cmd/gctcli/main.go

@@ -67,7 +67,7 @@ func setupClient(c *cli.Context) (*grpc.ClientConn, context.CancelFunc, error) {
 	if verbose {
 		c.Context = metadata.AppendToOutgoingContext(c.Context, "verbose", "true")
 	}
-	conn, err := grpc.DialContext(c.Context, host, opts...)
+	conn, err := grpc.NewClient(host, opts...)
 	return conn, cancel, err
 }