CB websocket tidying up #31
cranktakularAnnotations
10 errors and 11 warnings
|
lint:
exchanges/coinbasepro/coinbasepro_test.go#L131
Error return value of `c.API.Endpoints.SetDefaultEndpoints` is not checked (errcheck)
|
|
lint:
exchanges/coinbasepro/coinbasepro_test.go#L2016
Error return value of `u.UnmarshalJSON` is not checked (errcheck)
|
|
lint:
exchanges/coinbasepro/coinbasepro_test.go#L2073
Error return value of `c.Websocket.Disable` is not checked (errcheck)
|
|
lint:
exchanges/coinbasepro/coinbasepro_test.go#L2078
Error return value of `c.Websocket.Enable` is not checked (errcheck)
|
|
lint:
exchanges/coinbasepro/coinbasepro_test.go#L6
File is not `gci`-ed with --skip-generated -s standard -s default (gci)
|
|
lint:
exchanges/coinbasepro/coinbasepro_test.go#L11
File is not `gci`-ed with --skip-generated -s standard -s default (gci)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L1286
assignOp: replace `path = path + queryParams` with `path += queryParams` (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L1326
assignOp: replace `path = path + queryParams` with `path += queryParams` (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L1310
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L1319
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint:
exchanges/order/order_types.go#L365
exported: exported var AllOrderTypes should have comment or be unexported (revive)
|
|
lint:
exchanges/order/order_types.go#L444
exported: exported const StopUp should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L192
unused-parameter: parameter 'expiringContractStatus' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L425
unused-parameter: parameter 'retailPortfolioID' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L1147
unused-parameter: parameter 'transferType' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro_types.go#L641
exported: exported type ServerTimeV3 should have comment or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/ratelimit.go#L25
exported: exported const V2Rate should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L70
exported: exported const FiatDeposit should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro_websocket.go#L89
exported: exported function WOW should have comment or be unexported (revive)
|
|
lint:
exchanges/coinbasepro/coinbasepro.go#L807
exported: exported method CoinbasePro.GetUserByID should have comment or be unexported (revive)
|