Post-merge improvements #150
cranktakularAnnotations
10 errors and 1 warning
|
lint:
exchanges/bitget/bitget_wrapper.go#L48
Error return value of `bi.SetupDefaults` is not checked (errcheck)
|
|
lint:
exchanges/bitget/bitget_wrapper.go#L130
Error return value of `bi.API.Endpoints.SetDefaultEndpoints` is not checked (errcheck)
|
|
lint:
exchanges/bitget/bitget_websocket.go#L1068
appendCombine: can combine chain of 2 appends into one (gocritic)
|
|
lint:
exchanges/bitget/bitget_websocket.go#L271
builtinShadow: shadowing of predeclared identifier: close (gocritic)
|
|
lint:
exchanges/bitget/bitget_websocket.go#L786
builtinShadow: shadowing of predeclared identifier: close (gocritic)
|
|
lint:
exchanges/bitget/bitget_websocket.go#L1036
builtinShadow: shadowing of predeclared identifier: cap (gocritic)
|
|
lint:
exchanges/bitget/bitget_websocket.go#L876
hugeParam: wsResponse is heavy (168 bytes); consider passing it by pointer (gocritic)
|
|
lint:
exchanges/bitget/bitget_websocket.go#L903
hugeParam: wsResponse is heavy (168 bytes); consider passing it by pointer (gocritic)
|
|
lint:
exchanges/bitget/bitget_wrapper.go#L1176
paramTypeCombine: func(ctx context.Context, c currency.Code, _ string, chain string) (*deposit.Address, error) could be replaced with func(ctx context.Context, c currency.Code, _, chain string) (*deposit.Address, error) (gocritic)
|
|
lint:
exchanges/bitget/bitget_test.go#L2357
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|