Fixed issue #80: PHP error for non numeric values when using undefine…

…d variables.
craigk5n · Mar 5, 2018 · 729e69a · 729e69a
1 parent d31482f
commit 729e69a
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/edit_entry.php b/edit_entry.php
@@ -442,10 +442,13 @@ function time_selection ( $prefix, $time = '', $trigger = false ) {
   $rpt_type = 'none';
 
 // Avoid error for using undefined vars.
-if ( ! isset ( $hour ) && $hour != 0 )
-  $hour = -1;
-else
-if ( isset ( $hour ) && $hour >= 0 )
+if ( ! isset ( $hour ) || !is_numeric($hour))
+  $hour = 0;
+if (!isset ($minute)|| !is_numeric ($minute))
+  $minute = 0;
+else if ( isset ($hour) && is_numeric($hour) && $hour >= 0 ) {
+  $cal_time = ( $hour * 10000 ) + ( $minute * 100 );
+}
   $cal_time = ( $hour * 10000 ) + ( isset ( $minute ) ? $minute * 100 : 0 );
 
 if ( empty ( $access ) )
@@ -762,6 +765,8 @@ function time_selection ( $prefix, $time = '', $trigger = false ) {
               <td';
 
   if ( $eType != 'task' ) {
+    if (! isset($duration) || ! is_numeric($duration))
+      $duration = 0;
     $dur_h = intval ( $duration / 60 );
 
     echo '>&nbsp;</td>