Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich style of deploy finish/fail message #18

Merged
merged 6 commits into from
May 28, 2015

Conversation

Mekajiki
Copy link
Contributor

First of all I appreciate your useful gem, it's very useful and helps my daily work.

Sometimes it take a few seconds to recognize if a deployment failed or succeeded at a glance.
So I made some change to make them more recognizizable by

  • color messages depending on the outcome status.
  • separate status, stage, branch and revision into fields.
    using the attachment feature of slack.

As a result the messages look like as bellow:


1432800389

Mekajiki added 4 commits May 28, 2015 15:56
Sometimes I want to build more complex structure of payload.
For example a payload containing attachments.
In some case, I want embed text inside of an attachment, but in other
case not.
Passing text as a special parameter separated from the other parameters
doesn't allow me such a complexed payload composition.
So I pass block which compose payload.
- colorize the attachment with danger color.
- separate status, stage, branch and revision into fields.
- colorize the attachment with sky blue color.
- separate status, stage, branch and revision into fields.
@seenmyfate seenmyfate self-assigned this May 28, 2015
@foulkesjohn
Copy link

Why blue for success!?

@seenmyfate
Copy link
Contributor

@Mekajiki this is a great idea, thanks! I think it would be worth making some of the options (such as colour) configurable, but I'm happy to do that post-merge.

@Mekajiki
Copy link
Contributor Author

@foulkesjohn
Thx for a comment.
Mmm... this may be a cultural gap. Is it ok if it's good color(green) defined by slack?

@seenmyfate
I will make additional commits to configure the colors!

@seenmyfate
Copy link
Contributor

Great, good and danger feel like the right defaults to me 👍

@seenmyfate
Copy link
Contributor

Awesome, thanks - I'll get a new release put together shortly

seenmyfate added a commit that referenced this pull request May 28, 2015
Enrich style of deploy finish/fail message
@seenmyfate seenmyfate merged commit f4e8ccd into craigbrad:master May 28, 2015
@seenmyfate
Copy link
Contributor

This is now available via Rubygems as Version 2.3.0 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants