Removes identity number field on onboarding flow (#167)

* Removes identity number field on onboarding flow * Update
craftgate · Apr 1, 2024 · d7a9416 · d7a9416
1 parent f404981
commit d7a9416
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 12 deletions.
diff --git a/src/main/java/io/craftgate/request/CreateMemberRequest.java b/src/main/java/io/craftgate/request/CreateMemberRequest.java
@@ -16,7 +16,6 @@ public class CreateMemberRequest {
     private String address;
     private String email;
     private String phoneNumber;
-    private String identityNumber;
     private String contactName;
     private String contactSurname;
     private MemberType memberType;

diff --git a/src/main/java/io/craftgate/request/UpdateMemberRequest.java b/src/main/java/io/craftgate/request/UpdateMemberRequest.java
@@ -15,7 +15,6 @@ public class UpdateMemberRequest {
     private String address;
     private String email;
     private String phoneNumber;
-    private String identityNumber;
     private String contactName;
     private String contactSurname;
     private MemberType memberType;

diff --git a/src/main/java/io/craftgate/response/MemberResponse.java b/src/main/java/io/craftgate/response/MemberResponse.java
@@ -24,7 +24,6 @@ public class MemberResponse {
     private String email;
     private String address;
     private String phoneNumber;
-    private String identityNumber;
     private String contactName;
     private String contactSurname;
     private String legalCompanyTitle;

diff --git a/src/test/java/io/craftgate/sample/OnboardingSample.java b/src/test/java/io/craftgate/sample/OnboardingSample.java
@@ -32,7 +32,6 @@ void create_sub_merchant() {
                 .email("[email protected]")
                 .phoneNumber("905551111111")
                 .iban("TR930006701000000001111111")
-                .identityNumber("11111111110")
                 .legalCompanyTitle("Dem Zeytinyağı Üretim Ltd. Şti.")
                 .name("Dem Zeytinyağı Üretim Ltd. Şti.")
                 .memberType(MemberType.LIMITED_OR_JOINT_STOCK_COMPANY)
@@ -49,7 +48,6 @@ void create_sub_merchant() {
         assertEquals(request.getEmail(), response.getEmail());
         assertEquals(request.getPhoneNumber(), response.getPhoneNumber());
         assertEquals(request.getIban(), response.getIban());
-        assertEquals(request.getIdentityNumber(), response.getIdentityNumber());
         assertEquals(request.getLegalCompanyTitle(), response.getLegalCompanyTitle());
         assertEquals(request.getName(), response.getName());
         assertEquals(request.getMemberType(), response.getMemberType());
@@ -70,7 +68,6 @@ void update_sub_merchant() {
                 .contactSurname("Demir")
                 .email("[email protected]")
                 .phoneNumber("905551111111")
-                .identityNumber("11111111110")
                 .legalCompanyTitle("Dem Zeytinyağı Üretim Ltd. Şti.")
                 .name("Dem Zeytinyağı Üretim Ltd. Şti.")
                 .memberType(MemberType.LIMITED_OR_JOINT_STOCK_COMPANY)
@@ -88,7 +85,6 @@ void update_sub_merchant() {
         assertEquals(request.getEmail(), response.getEmail());
         assertEquals(request.getPhoneNumber(), response.getPhoneNumber());
         assertEquals(request.getIban(), response.getIban());
-        assertEquals(request.getIdentityNumber(), response.getIdentityNumber());
         assertEquals(request.getLegalCompanyTitle(), response.getLegalCompanyTitle());
         assertEquals(request.getName(), response.getName());
         assertEquals(request.getTaxNumber(), response.getTaxNumber());
@@ -123,7 +119,6 @@ void create_buyer() {
         assertEquals(request.getEmail(), response.getEmail());
         assertEquals(request.getPhoneNumber(), response.getPhoneNumber());
         assertEquals(request.getName(), response.getName());
-        assertEquals(request.getIdentityNumber(), response.getIdentityNumber());
     }
 
     @Test
@@ -181,7 +176,6 @@ void create_member_as_sub_merchant_and_buyer() {
                 .email("[email protected]")
                 .phoneNumber("905551111111")
                 .iban("TR930006701000000001111111")
-                .identityNumber("11111111110")
                 .legalCompanyTitle("Dem Zeytinyağı Üretim Ltd. Şti.")
                 .name("Dem Zeytinyağı Üretim Ltd. Şti.")
                 .memberType(MemberType.LIMITED_OR_JOINT_STOCK_COMPANY)
@@ -198,7 +192,6 @@ void create_member_as_sub_merchant_and_buyer() {
         assertEquals(request.getEmail(), response.getEmail());
         assertEquals(request.getPhoneNumber(), response.getPhoneNumber());
         assertEquals(request.getIban(), response.getIban());
-        assertEquals(request.getIdentityNumber(), response.getIdentityNumber());
         assertEquals(request.getLegalCompanyTitle(), response.getLegalCompanyTitle());
         assertEquals(request.getName(), response.getName());
         assertEquals(request.getMemberType(), response.getMemberType());

diff --git a/src/test/java/io/craftgate/unit/HashGeneratorTest.java b/src/test/java/io/craftgate/unit/HashGeneratorTest.java
@@ -11,13 +11,12 @@ public class HashGeneratorTest {
     @Test
     void should_generate_hash() {
         //given
-        String expectedSignature = "QQO5oHUUcNzHd9Sjc3RfDQbhHX1UqQiWsjYL3xoQaYA=";
+        String expectedSignature = "Tj0mkbp+WLBwLhS65CjX708PGCl9hD9rlT6n6Zgcyi8=";
         CreateMemberRequest request = CreateMemberRequest.builder()
                 .memberExternalId("ext-1511")
                 .email("[email protected]")
                 .phoneNumber("905551111111")
                 .name("Haluk Demir")
-                .identityNumber("11111111110")
                 .build();
 
         //when