Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3278. Migrate address fullName in commerce/upgrade #3288

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix #3278. Migrate address fullName in commerce/upgrade #3288

merged 1 commit into from
Oct 12, 2023

Conversation

joshuapease
Copy link
Contributor

Description

Fix for #3278

UpgradeController wasn't migrating the fullName field when calling _createAddress().

@joshuapease joshuapease requested a review from a team as a code owner October 3, 2023 17:53
@what-the-diff
Copy link

what-the-diff bot commented Oct 3, 2023

PR Summary

  • Improved Name Validation Logic
    This update brings in a new check in the system that ensures the 'Full Name' is properly set. This happens before the system attempts to combine your 'First Name' and 'Last Name'. By doing this, we ensure data consistency and avoid potential errors during this process.

@joshuapease joshuapease mentioned this pull request Oct 3, 2023
Closed
@lukeholder lukeholder merged commit b6862ae into craftcms:develop Oct 12, 2023
8 checks passed
@lukeholder
Copy link
Member

Thanks, this will be in the next release.

@joshuapease joshuapease deleted the address-migration-fullname-fix branch October 13, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuapease @lukeholder