Added transformGifs config setting, Fixes #2845

[andris-sevcenko]

Wanted to run this by someone as I'm not very happy with having to check for this in three different places. Something to be refactored later?

[brandonkelly]

Think you should add a FileHelper::isGif() method, similar to isSvg(), and call that wherever you're currently checking for .gif file extensions.

Also, I think we should leave the Asset::getThumb() method alone; thumbnails should still get transformed regardless of this setting.

[peter-tell]

The change:

if (FileHelper::isGif($this->filename) && !Craft::$app->getConfig()->getGeneral()->transformGifs) {
            return AssetsHelper::generateUrl($volume, $this);
        }

Is causing me to get:

finfo_file(MY-FILE.jpg): failed to open stream: No such file or directory

Error when running a transform through redactor

PHP version | 7.1.12
-- | --
MySQL 5.6.38
Imagick 3.4.3 (ImageMagick 6.9.6-2)
Craft Pro 3.0.7
Yii: 2.0.15.1
Twig: 2.4.8
Guzzle: 6.3.3
Imagine: 0.7-dev
Redactor | 2.0.1
-- | --

[andris-sevcenko]

Related to craftcms/redactor#47