Prevent Flash JS when deleting a Matrix block on the frontend #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an additional check to MatrixBlock.php@afterDelete to see if the request is coming from the frontend and if so, skip adding the Flash JS that causes templating problems.
|
Thanks for pointing that out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting matrix blocks from the front end of the site a number of cpresources are injected into the page at reload adding additional styling and a number of errors in the console.
The afterDelete method in src/elements/MatrixBlock.php is injecting the cpresources to clean up the browser's Local Storage of collapsed matrix blocks. As we're deleting them from the frontend, we don't need this functionality so I've updated the if statement to check if the request is a site request as well as a console request, and if so, skip including the cpresources.
This issue has also come up on the Craft CMS StackExchange:
https://craftcms.stackexchange.com/questions/25637/craft-3-resaving-matrix-from-frontend-causing-issues-craft-is-not-defined