Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FS URL validation #13657

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Fix FS URL validation #13657

merged 5 commits into from
Sep 11, 2023

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Sep 7, 2023

Makes URL actually required when hasUrls is true.

timkelty
timkelty commented Sep 7, 2023
View reviewed changes
src/base/Fs.php Outdated Show resolved Hide resolved
@brandonkelly brandonkelly merged commit bacf28d into develop Sep 11, 2023
@brandonkelly brandonkelly deleted the fix-fs-url-validation branch September 11, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonkelly brandonkelly Awaiting requested review from brandonkelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkelty @brandonkelly