Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent-child relationship not being conveyed to screen reader users #13020

Merged
merged 14 commits into from
Apr 3, 2023

Conversation

gcamacho079
Copy link
Contributor

Description

Adds visually-hidden text to structure table element cell that communicates nesting level

Related issues

@gcamacho079 gcamacho079 requested review from benjamindavid and a team as code owners March 30, 2023 19:55
@linear
Copy link

linear bot commented Mar 30, 2023

DEV-445 Parent-child relationship is not conveyed to screen reader users

Categories and structured entries

The hierarchy of structured entries and nested categories is conveyed via the left- or right-padding in the table cell of a child element. This style information is not able to be conveyed to SR users.

There should be another way of understanding the nesting of structured elements. This may be with the use of an additional table column that directly states the parent of the item in question.

Mockup:

Screen Shot 2022-07-13 at 1.13.51 PM.png

Resolves CMS-115

# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/pluginstore/dist/js/app.js
#	src/web/assets/pluginstore/dist/js/app.js.map
[ci skip]
@brandonkelly brandonkelly merged commit 2bdce98 into 4.5 Apr 3, 2023
@brandonkelly brandonkelly deleted the feature/dev-445-parent-child-relationship-is-not branch April 3, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants