only fclose the stream if it's a valid resource #12908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW This is happening with Azure Blob Storage as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Google Cloud Storage is done with the
$stream, it’s no longer recognised as a valid resource. It comes back withtype=Unknownand then causesfclose()to trigger an error:TypeError: fclose(): supplied resource is not a valid stream resource.Wrapping
fclose()in anis_resource()check makes it behave as expected. Also tested against Local FS and Amazon S3. In both cases,$streamis still a valid resource which makesfclose()work as expected.Related issues
#12878