let StringHelper::toAscii use language detection #12606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed up a simpler fix – just switched to running the tab name through |
|
Cool! I got hung up on keeping the anchor links human-friendly. |
|
Ah shoot, I didn’t think about that 🤦🏻 Just reverted that back a bit, so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Field layout tabs don’t show when the tab name is in a language that doesn’t easily convert to ASCII. This affects languages like Mandarin, Hebrew, Korean, Japanese and potentially others.
This PR adds language detection via patrickschur/language-detection to the
StringHelper::toAscii(only) if the current approach returns an empty string.Related issues
#12602