Use index hints to specify index so Mysql does not select the less pe… #11825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjeng thanks for that... any chance you could send a database dump and the full SQL query in the screenshot over to [email protected] so we can do some local testing? |
|
I can do that! I'll package up the db dump and send it over as soon as I'm able. |
|
I've sent the code and query. Please let me know if you need anymore info. |
|
Merged for the next release! |
|
That's great news, thank you! |
|
Craft 4.2.4 is tagged with that change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rformant index.
Description
Mysql is using the wrong index in a subquery for
structurestable when there are a lot of records. The result is that the overall query gets super slow to complete. This is compounded by the fact that the subquery is used in multiple places in the control panel, and sometimes multiple times in a single request.The recent entries widget is one place where the query is used and below is an example of load time:
And here is the difference after applying index hint:
To be fair, the above example is an extreme one, but I'm seeing improvement in other problematic areas as well (edit pages of complex entries).
The proposed code change should not be very disruptive, and should be very specific to the
existsubquery and also only when using MySQL db.