Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to create paths dirs before checking realpath #10562

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Conversation

timkelty
Copy link
Contributor

With an env like:

CRAFT_STORAGE_PATH=/tmp/storage/

We need to create that dir before doing realpath, or they will always come back false if they don't exist yet.

@brandonkelly brandonkelly deleted the create-dirs branch April 2, 2022 00:17
@brandonkelly brandonkelly restored the create-dirs branch April 2, 2022 00:18
@brandonkelly brandonkelly reopened this Apr 2, 2022
@timkelty timkelty requested a review from a team as a code owner April 2, 2022 00:33
@brandonkelly brandonkelly merged commit 387d586 into 4.0 Apr 2, 2022
@brandonkelly brandonkelly deleted the create-dirs branch April 2, 2022 22:48
@brandonkelly
Copy link
Member

Craft 4.0.0-beta.4 is out now with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants