Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nl2br on fields instructions #3928

Closed
piotrpog opened this issue Feb 28, 2019 · 5 comments
Closed

Use nl2br on fields instructions #3928

piotrpog opened this issue Feb 28, 2019 · 5 comments
Labels
authoring ✍️ features related to author experience enhancement improvements to existing features

Comments

@piotrpog
Copy link

Changing newlines to <br>s would make intructions more readable.
@brandonkelly brandonkelly added enhancement improvements to existing features authoring ✍️ features related to author experience labels Mar 3, 2019
@brandonkelly
Copy link
Member

Easy enough. Just added this for the next release!

@putyourlightson
Copy link

putyourlightson commented Mar 6, 2019 •
edited
Loading

Hmm, this seems to have broken all info tooltips that my plugins use, likely because nl2br pre-escapes HTML. I realise the original request is valid, but probably not worth it if it will break a bunch of plugins? Craft used to use these info tooltips but it seems to have done away with most if not all of them.

screenshot 2019-03-06 at 14 14 28

@piotrpog
Copy link
Author

piotrpog commented Mar 6, 2019

@putyourlightson
Then how about simple config variable that would enable or disable nl2br on field instructions?

brandonkelly added a commit that referenced this issue Mar 6, 2019
@brandonkelly
Don't HTML-encode field instructions (#3928)
1f72a7c
@brandonkelly
Copy link
Member

@putyourlightson Nothing a |raw filter can’t fix :)

@putyourlightson
Copy link

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
authoring ✍️ features related to author experience enhancement improvements to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonkelly @piotrpog