Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Config's dateModified is updated even when there are no changes #3792

Closed
boboldehampsink opened this issue Feb 6, 2019 · 7 comments
Closed

Project Config's dateModified is updated even when there are no changes #3792

boboldehampsink opened this issue Feb 6, 2019 · 7 comments
Assignees
@andris-sevcenko
Labels
enhancement improvements to existing features project config 🐫 features related to Project config

Comments

@boboldehampsink
Copy link
Contributor

Description

I wonder if it is necessary to update the project.yaml dateModified when there's no changes? Makes me have to commit or discard it every time.

Steps to reproduce

  1. Install a new Craft project from an existing project.yaml
  2. After running install, run craft project-config/sync
  3. project.yaml's dateModified is updated, but nothing else

Additional info

  • Craft version: 3.1.8
  • PHP version: 7.3.1
  • Database driver & version: PostgreSQL 10.6
  • Plugins & versions: N/A
@brandonkelly brandonkelly added enhancement improvements to existing features project config 🐫 features related to Project config labels Feb 6, 2019
@andris-sevcenko
Copy link
Contributor

This has been resolved with c20adf2

@boboldehampsink
Copy link
Contributor Author

Just updated to 3.1.12 but this still happens

@jorenvanhee
Copy link

Can confirm. Only happens when applying a project-config file to a fresh Craft installation.

@brandonkelly
Copy link
Member

@boboldehampsink Is that where you were seeing this too—when installing Craft?

@boboldehampsink
Copy link
Contributor Author

Yes, see description

@brandonkelly
Copy link
Member

Sorry, missed that. Why is step 2 necessary in the first place? There shouldn’t be any chances left to sync after installing Craft with an existing config/project.yaml file.

@boboldehampsink
Copy link
Contributor Author

In case Craft is already installed

andris-sevcenko added a commit that referenced this issue Feb 25, 2019
@andris-sevcenko
Fixed #3792 some more.
8576a75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andris-sevcenko andris-sevcenko

Labels
enhancement improvements to existing features project config 🐫 features related to Project config
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brandonkelly @jorenvanhee @boboldehampsink @andris-sevcenko