Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devmode banner element doesn't show up on some browsers (DPI scaling) #3259

Closed
jamesmacwhite opened this issue Sep 3, 2018 · 6 comments
Closed

Comments

@jamesmacwhite
Copy link
Contributor

jamesmacwhite commented Sep 3, 2018

Description

The devmode SVG patterned banner does not show up on some browsers. Weirdly, its appearing in Google Chrome on Mac, but with Google Chrome on Windows it doesn't show and in other browsers as well.

Not quite sure why, initially I thought about adding the position property, but this will cause uneven spacing, instead adding min-height seems to work.

Additional info

  • Craft version: 2.7.2
@brandonkelly
Copy link
Member

Working on my end:

screen shot 2018-09-03 at 8 01 26 am

Do you have any plugins installed that could be messing with the CSS?

@jamesmacwhite
Copy link
Contributor Author

@brandonkelly We do and I initially thought this was the case, however inspecting the element in Chrome I cannot see any overrides/other rules from anything else and the fact because it works on equivalent browsers on Mac, I figured it can't be, otherwise it would be consistent. I'll double check, but its bizarre.

@jamesmacwhite
Copy link
Contributor Author

jamesmacwhite commented Sep 3, 2018

@brandonkelly Right. Found out what it is. Its Windows 10 and its derpy DPI scaling. My Dell XPS 9550 is at 125% scaling, in Chrome and other browsers the banner is not visible, setting it back to 100% system wide I can see the banner. Nice one Microsoft.

Is that min-height fix still possible in this case? It seems like a hack, but it doesn't appear to cause an issues for other browsers and perhaps normal DPI.

@jamesmacwhite jamesmacwhite changed the title Devmode banner element doesn't show up on some browsers Devmode banner element doesn't show up on some browsers (DPI scaling) Sep 3, 2018
@brandonkelly
Copy link
Member

@jamesmacwhite Glad you figured out the culprit! Happy to include the change if it’s not hurting anything.

@jamesmacwhite
Copy link
Contributor Author

@brandonkelly Thanks! Will this be back ported to Craft 2 at some point? If not don't worry, I will implement this fix in my plugin that loads additional CSS in the CP.

@brandonkelly
Copy link
Member

Gah, sorry, I forgot this is for Craft 2. Will add there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants