Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table field "Min Rows" setting behavior is off #2864

Closed
chasegiunta opened this issue May 9, 2018 · 0 comments
Closed

Table field "Min Rows" setting behavior is off #2864

chasegiunta opened this issue May 9, 2018 · 0 comments
Assignees

Comments

@chasegiunta
Copy link
Contributor

chasegiunta commented May 9, 2018

Description

The min rows setting on table fields cause incorrect behavior. (JS issue)

For the most reduced test case, creating a new field & setting the min rows to 1 disables the add row button and won't allow the editor add any rows at all. It remains a useless table field.

Setting the min rows setting to 2 will automatically add a single blank row upon page-load but won't allow the editor to add an additional row.

Steps to reproduce

  1. Create new table field.
  2. Set to min rows setting to 1, save.
  3. Add field to applicable entry type, save.
  4. Navigate to applicable entry type.
  5. Face palm.
  6. Repeat steps 1-5 with min rows setting set to 2.

Additional info

  • Craft version: 3.0.6
brandonkelly added a commit that referenced this issue May 14, 2018
Improved logic for Tables min/max rows Fixed #2864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants