Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Preview will show any disabled Matrix blocks #13

Closed
angrybrad opened this issue Jan 29, 2017 · 3 comments
Closed

Live Preview will show any disabled Matrix blocks #13

angrybrad opened this issue Jan 29, 2017 · 3 comments
Assignees
Labels
bug severity:minor Cosmetic issues or bugs with simple workarounds wontfix

Comments

@angrybrad
Copy link
Member

Environment:

  • Craft version: 3.x
  • PHP version: 7.x
  • Database driver & version: n/a
  • Plugins & versions:

Description:

If you have a template that loops over Matrix blocks and some of those Matrix blocks are disabled, they will show up on a Live Preview request (but they won't show up on a normal, front-end request).

@angrybrad angrybrad added bug severity:normal Bugs that affect typical usage labels Jan 29, 2017
@brandonkelly brandonkelly added severity:minor Cosmetic issues or bugs with simple workarounds and removed severity:normal Bugs that affect typical usage labels Feb 3, 2017
@brandonkelly brandonkelly self-assigned this Feb 24, 2017
@brandonkelly
Copy link
Member

Nothing we can really do about this. On Live Preview requests, the Matrix field is set to whatever blocks were posted in the request, as if they had been eager-loaded.

If it is undesired, the template would just need to be updated to check the blocks' statuses before displaying them.

There is an argument that it could be desired though - in the same way you would expect Live Preview to show you the entire entry you are editing, even if that entry is disabled.

@brandonkelly
Copy link
Member

Ugh fine, I ended up talking myself into this.

@narration-sd
Copy link
Contributor

Good man ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug severity:minor Cosmetic issues or bugs with simple workarounds wontfix
Projects
None yet
Development

No branches or pull requests

3 participants