Fixed #3450

CHANGELOG-v3.md

@@ -13,6 +13,7 @@
 - Fixed a bug where the `positionedBefore` element query param was not including direct ancestors in the results.
 - Fixed a bug where HTML in plugin-supplied field instructions was getting encoded. ([#3928](https://github.com/craftcms/cms/issues/3928))
 - Fixed a bug where Craft would prompt for a user’s current password when registering a new user, even if they weren’t assigning any groups or permissions to that user
+- Fixed a bug where a race condition could make Asset indexing inconsistent. ([#3450](https://github.com/craftcms/cms/issues/3450))
 
 ## 3.1.16 - 2019-03-05
 

src/services/AssetIndexer.php

@@ -233,13 +233,22 @@ public function storeIndexList(array $indexList, string $sessionId, int $volumeI
      */
     public function processIndexForVolume(string $sessionId, int $volumeId, bool $cacheImages = false)
     {
+        $mutex = Craft::$app->getMutex();
+        $lockName = 'idx--' . $sessionId;
+
+        if (!$mutex->acquire($lockName, 5)) {
+            throw new Exception('Could not acquire a lock for the indexing sessiong "' . $sessionId . '".');
+        }
+
         if (($indexEntryModel = $this->getNextIndexEntry($sessionId, $volumeId)) === null) {
             return false;
         }
 
         // Mark as started.
         $this->updateIndexEntry($indexEntryModel->id, ['inProgress' => true]);
 
+        $mutex->release($lockName);
+
         try {
             $asset = $this->_indexFileByIndexData($indexEntryModel, $cacheImages);
             $this->updateIndexEntry($indexEntryModel->id, ['completed' => true, 'inProgress' => false, 'recordId' => $asset->id]);