Only register asset bundle / JS flashes on CP requests

Resolves #4390
craftcms · Jun 11, 2019 · 18487ce · 18487ce
1 parent 1b26171
commit 18487ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG-v3.md b/CHANGELOG-v3.md
@@ -11,6 +11,7 @@
 - Fixed a bug where Craft was modifying custom log target configs before executing queue jobs. ([#3766](https://github.com/craftcms/cms/issues/3766))
 - Fixed a bug where `craft\helpers\ChartHelper::getRunChartDataFromQuery()` assumed that the value would be integers. ([craftcms/commerce#849](https://github.com/craftcms/commerce/issues/849))
 - Fixed a bug where `craft\services\Security::validateData()` was returning an empty string instead of `false` when the data didn’t validate. ([#4387](https://github.com/craftcms/cms/issues/4387))
+- Fixed a bug where Craft could inject unexpected JavaScript into front-end requests. ([#4390](https://github.com/craftcms/cms/issues/4390))
 
 ## 3.1.29 - 2019-06-04
 

diff --git a/src/web/View.php b/src/web/View.php
@@ -1453,7 +1453,7 @@ protected function renderBodyEndHtml($ajaxMode)
      */
     protected function registerAssetFlashes()
     {
-        if (Craft::$app->getRequest()->getIsConsoleRequest()) {
+        if (!Craft::$app->getRequest()->getIsCpRequest()) {
             return;
         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -1453,7 +1453,7 @@ protected function renderBodyEndHtml($ajaxMode) @@
          */
         protected function registerAssetFlashes()
         {
-            if (Craft::$app->getRequest()->getIsConsoleRequest()) {
+            if (!Craft::$app->getRequest()->getIsCpRequest()) {
                 return;
             }
@@ Expand Down @@