Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes KBH import hop times #101

Closed
wants to merge 1 commit into from
Closed

fixes KBH import hop times #101

wants to merge 1 commit into from

Conversation

prash3r
Copy link
Contributor

@prash3r prash3r commented Aug 10, 2022

fixes #100

my test recipe looks like this:
grafik
and the relevant part of the resulting sqlite table looks like this:
grafik
If you look at the column Vorderwuerze you see that there are different Values possible then 0 or 1. From my testing and understanding it should work like this:

  1. Vorderwürze=pre_boil=1
  2. Kochbeginn=boil_start=2
  3. Kochen=boiling=3
  4. Kochende=boiling_finish=4
  5. Ausschlag=Wirlpool=5

Since the time value is still provided i hope i can just differentiate between Vorderwürze=1 and all others <> 1 to create the intended result.

With my test recipe it seems to work out great:
grafik

EDIT:
I tested the negative hop timer value for Whirlpool additions and the notification is of course missing. Alle the other notifications came as expected so i guess this still fixes the issue at hand.

@avollkopf
Copy link
Contributor

Currently, activity is only on my branch. I will change it there in the development branch, but will disable the '5' for now as negative times are not supported.

@prash3r prash3r closed this by deleting the head repository Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KBH import doesnt import hop times
2 participants