Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Snapping grid for dashboard #97

Open
fuzzewuzze opened this issue Jul 17, 2022 · 1 comment
Open

Suggestion: Snapping grid for dashboard #97

fuzzewuzze opened this issue Jul 17, 2022 · 1 comment

Comments

@fuzzewuzze
Copy link

Maybe its the ADHD in me, but not having a grid that i can snap my text or items to in order to ensure they are aligned properly bugs me.

I'd like to recommend some type of snapping grid, or a static grid to align objects manually.

@prash3r
Copy link
Contributor

prash3r commented Aug 10, 2022

i would vote against this. technically you have a snapping grid with the precision of 1 pixel. if you want to align using this you can always just find the cbpi_dashboard_{n}.json and change the coordinate numbers if your urge to alignment is too much to bear.

problem with a snapping grid would be with any custom svg or even the included svg files and elements that the pipes would never align on the snapping grid. for example the image for a valve has its pipe attachment at an offset while the pipe attachment on the pipe is not offset so alignment would be even worse to achieve. "the snapping grid wouldnt know where the pipe attachment is displayed in the (custom) image so it would not be able to snap to pipes". To solve this the complexity just skyrockets and we should not do it, its fine like it is.

Imagine these two images snapping to the grid on the left just like displayed here:
grafik
grafik

if you can imagine them aligned to the center you see it wont work either and to the right wouldnt work either. snapping this is complex.

papauorg pushed a commit to papauorg/craftbeerpi4 that referenced this issue Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants