Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid blank page on safari and firefox #682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acapellacci
Copy link

Blank page issue still occurs with Firefox v114 and Safari. For this reason I propose to add a delay for both browsers and all versions.

@fs-nathan
Copy link

Hi @crabbly
Could you please take a look on this PR?
It resolves the issue mentioned here: #528

Thanks @crabbly @acapellacci

@amoilanen
Copy link
Contributor

amoilanen commented Jul 26, 2023

@acapellacci The most recent version of Print.js has not yet been published, unfortunately, so the chances are that the master branch actually works with Firefox v114?

Do you have the issue with Firefox v114 using print-js-updated #665 (comment) ?

@amoilanen
Copy link
Contributor

@acapellacci

At least it was proven in the past that Firefox 110.0 does not work with the added timeout, so this PR might inadvertently reintroduce #665 for Firefox 110.0 ?

If the timeout is needed for more recent versions of Firefox (114) and for some earlier versions (110.0) it should be removed, the condition should probably be still kept and needs to be more specific about the Firefox version?

@acapellacci
Copy link
Author

@acapellacci

At least it was proven in the past that Firefox 110.0 does not work with the added timeout, so this PR might inadvertently reintroduce #665 for Firefox 110.0 ?

If the timeout is needed for more recent versions of Firefox (114) and for some earlier versions (110.0) it should be removed, the condition should probably be still kept and needs to be more specific about the Firefox version?

The issue occures in Safari 16.6 and Firefox 115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants