Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): add missing dependencies #6

Merged
merged 1 commit into from
Sep 14, 2020
Merged

fix(template): add missing dependencies #6

merged 1 commit into from
Sep 14, 2020

Conversation

hongbo-miao
Copy link
Contributor

@hongbo-miao hongbo-miao commented Sep 11, 2020 •
edited
Loading

For TypeScript version, after running

npx create-react-app my-app --template cra-template-pwa-typescript

missed these four files currently in able for the app to run:

"@types/react": "^16.9.49",
"@types/react-dom": "^16.9.8",
"typescript": "^4.0.2",
"web-vitals": "^0.2.4",

For JavaScript version, after running

npx create-react-app my-app --template cra-template-pwa

missed these one file currently in able for the app to run:

"web-vitals": "^0.2.4",

@jeffposnick jeffposnick self-requested a review September 14, 2020 19:40
jeffposnick
jeffposnick approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeffposnick jeffposnick merged commit ae7882e into cra-template:master Sep 14, 2020
@hongbo-miao
Copy link
Contributor Author

You are welcome!

@jeffposnick jeffposnick mentioned this pull request Sep 14, 2020
Closed
@jeffposnick
Copy link
Collaborator

(I've pushed the updates to npm.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffposnick jeffposnick jeffposnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongbo-miao @jeffposnick