Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Darkened contribution calendar. #34

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AlexMeuer
Copy link

What's the issue:

Contribution calendar was still showing up with usual bright colours.

What's fixed:

I darkened the calendar with the css from Github Dark 1.

Screenshots:

contrib_calendar

@oubiwann
Copy link

I almost like this :-) I really do like contributions heatmap from v1, but the grid background is too dark. I found that if I used #364952 instead, the calendar looks really great ...

Another thought occurred to me: since this theme has a bit more colour in it than v1, what about adding more colour to the heatmap? Dunno ... might not be enough gradations for that.

@cquanu cquanu added the willfix label Dec 21, 2016
Copy link
Contributor

@snowe2010 snowe2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a bit out of date. If it could be updated so that it works I'll review it again. Thanks!

Include minified css.
@AlexMeuer
Copy link
Author

AlexMeuer commented Feb 2, 2018

Only modified css relevant to the calendar. I had to tweak/remove some errors to get it working with stylish for me, but I left those out of the commit.
contrib
I'm not sure about the cell background; it feels too close to the first contribution color, but the background in the first image feels too dark.

@snowe2010
Copy link
Contributor

Something in these changes is causing the PR review comment to have a white border.
screenshot 2018-02-02 16 38 55

opacity: 1;
/* }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue here.

@@ -2155,6 +2153,8 @@ li.session-device {

/* End */

=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover from merge conflict

@snowe2010
Copy link
Contributor

How do you feel about #03A9F4 for the fill? It's the link color (per CONTRIBUTING.md) and it looks pretty good to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants