Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to suggest to use inline classes when a class has single property #698

Closed
petertrr opened this issue Jan 12, 2021 · 1 comment · Fixed by #716
Closed

Add warning to suggest to use inline classes when a class has single property #698

petertrr opened this issue Jan 12, 2021 · 1 comment · Fixed by #716
Assignees
@aktsay6
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@petertrr
Copy link
Member

https://kotlinlang.org/docs/reference/inline-classes.html

However, only since 1.3. Maybe needs some more considerations.
@petertrr petertrr added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 12, 2021
@aktsay6 aktsay6 self-assigned this Jan 19, 2021
@petertrr
Copy link
Member Author

@aktsay6 also add this rule to codestyle

aktsay6 added a commit that referenced this issue Jan 19, 2021
@aktsay6
feature/inline-classes(#698)
bf7133e 
### What's done:
  * Logic made
  * Added warn tests
@aktsay6 aktsay6 mentioned this issue Jan 19, 2021
Merged
5 tasks
aktsay6 added a commit that referenced this issue Jan 19, 2021
@aktsay6
feature/inline-classes(#698)
3a3e1a2 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 19, 2021
@aktsay6
feature/inline-classes(#698)
0db1a08 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 19, 2021
@aktsay6
feature/inline-classes(#698)
7816893 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 19, 2021
@aktsay6
feature/inline-classes(#698)
41da95c 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 19, 2021
@aktsay6
feature/inline-classes(#698)
262c513 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 19, 2021
@aktsay6
feature/inline-classes(#698)
82cd263 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 19, 2021
@aktsay6
feature/inline-classes(#698)
f866e6f 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 20, 2021
@aktsay6
feature/inline-classes(#698)
8869988 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 20, 2021
@aktsay6
feature/inline-classes(#698)
91568a2 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 21, 2021
@aktsay6
feature/inline-classes(#698)
ca994dd 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 21, 2021
@aktsay6
feature/inline-classes(#698)
79d7a2c 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 21, 2021
@aktsay6
Merge branch 'master' into feature/inline-classes(#698)
edc0fa9 
# Conflicts:
#	diktat-rules/src/main/kotlin/generated/WarningNames.kt
aktsay6 added a commit that referenced this issue Jan 21, 2021
@aktsay6
feature/inline-classes(#698)
00e135b 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 21, 2021
@aktsay6
feature/inline-classes(#698)
5d41510 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 21, 2021
@aktsay6
feature/inline-classes(#698)
f4d0ca4 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 25, 2021
@aktsay6
Merge branch 'master' into feature/inline-classes(#698)
fea5172
@petertrr petertrr mentioned this issue Jan 25, 2021
Closed
aktsay6 added a commit that referenced this issue Jan 26, 2021
@aktsay6
feature/inline-classes(#698)
fadb4b2 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 26, 2021
@aktsay6
feature/inline-classes(#698)
7bc2826 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 26, 2021
@aktsay6
Merge branch 'master' into feature/inline-classes(#698)
50c12b8 
# Conflicts:
#	diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt
aktsay6 added a commit that referenced this issue Jan 26, 2021
@aktsay6
feature/inline-classes(#698)
a786c82 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 26, 2021
@aktsay6
feature/inline-classes(#698)
55295a2 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 27, 2021
@aktsay6
Merge branch 'master' into feature/inline-classes(#698)
824af31
aktsay6 added a commit that referenced this issue Jan 27, 2021
@aktsay6
Add warning to suggest to use inline classes when a class has single …
05c3ebb 
…property (#716)

* feature/inline-classes(#698)

### What's done:
  * Logic made
  * Added warn tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aktsay6 aktsay6

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add warning to suggest to use inline classes when a class has single property saveourtool/diktat
2 participants
@petertrr @aktsay6