You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Quite impressed about the automation of the docker images creation you put in place here, I must say... Cool stuff ! 👍 .
Not sure about the initial history of your Dockerfile (and the other atlassian Dockerfile you initiated), but I could find some changes made the official Atlassian Dockerfile (at least up to version 6.3 as they are moving to Alpine after that) that includes some cleanup that might be interesting to introduce here, and that will not change the behavior of the image:
Introduction of environment variables for:
daemon (RUN_USER and RUN_GROUP)
CONF_DOWNLOAD_URL
MYSQL_VERSION
MYSQL_DRIVER_DOWNLOAD_URL
usage of CONF_INSTALL and CONF_HOME in more places
What about adding them ? Will create a pull request.
Em
The text was updated successfully, but these errors were encountered:
esciara
added a commit
to esciara/docker-atlassian-confluence
that referenced
this issue
Sep 19, 2017
Hi @cptactionhank ,
Quite impressed about the automation of the docker images creation you put in place here, I must say... Cool stuff ! 👍 .
Not sure about the initial history of your Dockerfile (and the other atlassian Dockerfile you initiated), but I could find some changes made the official Atlassian Dockerfile (at least up to version 6.3 as they are moving to Alpine after that) that includes some cleanup that might be interesting to introduce here, and that will not change the behavior of the image:
daemon
(RUN_USER
andRUN_GROUP
)CONF_DOWNLOAD_URL
MYSQL_VERSION
MYSQL_DRIVER_DOWNLOAD_URL
CONF_INSTALL
andCONF_HOME
in more placesWhat about adding them ? Will create a pull request.
Em
The text was updated successfully, but these errors were encountered: