Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] update octave install for ubuntu 24.04 #1336

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jan 9, 2025

Summary by Sourcery

CI:

  • Update Octave installation in CI workflows to use the octave-dev package.

Copy link
Contributor

sourcery-ai bot commented Jan 9, 2025

Reviewer's Guide by Sourcery

This pull request updates the installation of Octave for Ubuntu 24.04 by replacing the liboctave-dev package with octave-dev.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replaced liboctave-dev with octave-dev to fix Octave installation on Ubuntu 24.04.
  • Changed the apt-get install command to use octave-dev instead of liboctave-dev.
  • Updated all Octave installation steps to use the new package name across all workflows.
.github/workflows/run_tests_cli.yml
.github/workflows/tests_octave.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Remi-Gau - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (f53979a) to head (7452cdb).
Report is 149 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1336      +/-   ##
==========================================
+ Coverage   79.57%   81.75%   +2.17%     
==========================================
  Files         285      284       -1     
  Lines        7742     7746       +4     
  Branches       40        0      -40     
==========================================
+ Hits         6161     6333     +172     
+ Misses       1565     1413     -152     
+ Partials       16        0      -16     
Flag Coverage Δ
cli ?
macos-13_matlab-R2023b_fast 63.32% <ø> (?)
macos-13_matlab-R2023b_slow 58.66% <ø> (?)
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave 76.56% <ø> (+0.85%) ⬆️
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?
ubuntu-latest_matlab-R2023b_fast 63.32% <ø> (?)
ubuntu-latest_matlab-R2023b_slow 59.15% <ø> (?)
windows-latest_matlab-R2023b_fast 63.32% <ø> (?)
windows-latest_matlab-R2023b_slow 58.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 532771f into cpp-lln-lab:main Jan 10, 2025
33 of 34 checks passed
@Remi-Gau Remi-Gau deleted the maint/octave branch January 10, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant