Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solves #98 #99

Merged
merged 1 commit into from
Sep 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/mkdocs-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ jobs:
with:
python-version: 3.x
- name: Install python action for doc extraction
run: pip install . -r docs/requirements.txt
run: pip install -r docs/requirements.txt
- name: check mkdocs build
if: github.ref != 'refs/heads/master'
# if: github.ref != 'refs/heads/master'
run: mkdocs build
- name: Build docs and deploy to gh-pages
if: github.ref == 'refs/heads/master'
run: |
git config user.name 'github-actions'
git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
mkdocs gh-deploy --force
# - name: Build docs and deploy to gh-pages
# if: github.ref == 'refs/heads/master'
# run: |
# git config user.name 'github-actions'
# git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
# mkdocs gh-deploy --force
51 changes: 0 additions & 51 deletions .github/workflows/publish-pypi.yml

This file was deleted.

113 changes: 0 additions & 113 deletions .github/workflows/run-dev-tests.yml

This file was deleted.

2 changes: 0 additions & 2 deletions .gitpod.yml

This file was deleted.

28 changes: 0 additions & 28 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,33 +4,5 @@ repos:
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
- id: check-docstring-first
- id: check-added-large-files
- id: check-yaml
- id: check-toml
- id: requirements-txt-fixer
- repo: https://github.com/python/black
rev: '22.6.0'
hooks:
- id: black
args: ["--diff"]
- repo: https://github.com/pycqa/pylint
rev: v2.14.5
hooks:
- id: pylint
name: pylint (action code)
types: [python]
exclude: "^(docs/|tests/|setup.py$)"
additional_dependencies: [pyyaml, requests]
- repo: local
# this is a "local" hook to run mypy (see https://pre-commit.com/#repository-local-hooks)
# because the mypy project doesn't seem to be compatible with pre-commit hooks
hooks:
- id: mypy
name: mypy
description: type checking with mypy tool
language: python
types: [python]
entry: mypy
exclude: "^(docs/|setup.py$)"
additional_dependencies: [mypy, types-pyyaml, types-requests, rich, requests, pytest, pyyaml, '.']
4 changes: 1 addition & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ LABEL maintainer="shenxianpeng <[email protected]>"

RUN apt-get update && apt-get -y install python3-pip

COPY cpp_linter/ pkg/cpp_linter/
COPY pyproject.toml pkg/pyproject.toml
RUN python3 -m pip install pkg/
RUN python3 -m pip install cpp-linter
shenxianpeng marked this conversation as resolved.
Show resolved Hide resolved

# github action args use the CMD option
# See https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsargs
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
[![GitHub Workflow Status](https://img.shields.io/github/workflow/status/cpp-linter/cpp-linter-action/cpp-linter?label=cpp-linter&logo=Github&style=flat-square)](https://github.com/cpp-linter/cpp-linter-action/actions/workflows/cpp-linter.yml)
[![GitHub Workflow Status](https://img.shields.io/github/workflow/status/cpp-linter/cpp-linter-action/MkDocs%20Deploy?label=docs&logo=Github&style=flat-square)](https://github.com/cpp-linter/cpp-linter-action/actions/workflows/mkdocs-deploy.yml)
![GitHub](https://img.shields.io/github/license/cpp-linter/cpp-linter-action?label=license&logo=github&style=flat-square)
[![codecov](https://codecov.io/gh/cpp-linter/cpp-linter-action/branch/master/graph/badge.svg?token=4SF7UEDEZ2)](https://codecov.io/gh/cpp-linter/cpp-linter-action)

A Github Action for linting C/C++ code integrating clang-tidy and clang-format to collect feedback provided in the form of thread comments and/or annotations.

Expand Down Expand Up @@ -187,7 +186,7 @@ jobs:
directory: ${{ runner.temp }}/llvm

- name: Install linter python package
run: python3 -m pip install git+https://github.com/cpp-linter/cpp-linter-action@v1
run: python3 -m pip install cpp-linter

- name: run linter as a python package
id: linter
Expand Down Expand Up @@ -219,7 +218,7 @@ is equivalent to

```yaml
- name: Install linter python package
run: python3 -m pip install git+https://github.com/cpp-linter/cpp-linter-action@v1
run: python3 -m pip install cpp-linter

- name: run linter as a python package
run: |
Expand Down
Loading