Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove publish-pypi.yml (Upload Python Package) #91

Closed
Tracked by #87
shenxianpeng opened this issue Aug 29, 2022 · 2 comments
Closed
Tracked by #87

Remove publish-pypi.yml (Upload Python Package) #91

shenxianpeng opened this issue Aug 29, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@shenxianpeng
Copy link
Collaborator

Upload Python Package failed in v1.5.0 release https://github.com/cpp-linter/cpp-linter-action/runs/8055353233?check_suite_focus=true

Since we have abstract python sources from cpp-linter-action to cpp-linter repo cpp-linter/cpp-linter#1 and publish to PyPI with cpp-linter repo, since in the next release (v2), the file .github/workflows/publish-pypi.yml can be removed.
@shenxianpeng shenxianpeng added the bug Something isn't working label Aug 29, 2022
@shenxianpeng shenxianpeng mentioned this issue Aug 29, 2022
Closed
8 tasks
@2bndy5
Copy link
Collaborator

2bndy5 commented Aug 29, 2022

The secret tokens should be removed as well. I think they are now invalid since the release of the cpp-linter pkg (v1.4.6).

@shenxianpeng
Copy link
Collaborator Author

OK. I have removed PYPI_API_TOKEN and TEST_PYPI_TOKEN.

shenxianpeng added a commit that referenced this issue Aug 31, 2022
@shenxianpeng
Remove publish-pypi.yml #91
507d5a6
2bndy5 pushed a commit that referenced this issue Sep 1, 2022
@shenxianpeng
Change action from docker to composite (#83)
bfc328f 
* Change action from docker to composite
* Remove Dockerfile
* install cpp-linter pkg from PyPI
* Remove publish-pypi.yml #91
* Switch from master to main branch
* Add CONTRIBUTING.md
@2bndy5 2bndy5 closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shenxianpeng @2bndy5