Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly added latest tag for PR testing and not trigger test action #212

Closed
shenxianpeng opened this issue Mar 20, 2024 · 2 comments · Fixed by #217
Closed

Incorrectly added latest tag for PR testing and not trigger test action #212

shenxianpeng opened this issue Mar 20, 2024 · 2 comments · Fixed by #217
Labels
bug Something isn't working

Comments

@shenxianpeng
Copy link
Collaborator

I saw the latest commit on the main branch was still adding comments 599f02b

Not sure why and how to fix it yet but opening an issue for awareness. maybe the code here needs to be adjusted (haven't looked at it)

https://github.com/cpp-linter/cpp-linter-action/actions/runs/8353366407/workflow#L21-L28
@shenxianpeng shenxianpeng added the bug Something isn't working label Mar 20, 2024
@shenxianpeng shenxianpeng changed the title Incorrectly added latest tag for PR testing Incorrectly added latest tag for PR testing and not trigger test action Mar 20, 2024
@shenxianpeng
Copy link
Collaborator Author

shenxianpeng commented Mar 20, 2024 •
edited
Loading

  • Recently, the cpp-linter/test-cpp-linter-action is not automatically triggered after the PR

@2bndy5
Copy link
Collaborator

2bndy5 commented Mar 20, 2024 

          git tag --delete latest || true
          git push --delete origin latest || true

Maybe the || true is hidding problems that need to be addressed.

@shenxianpeng shenxianpeng mentioned this issue Mar 21, 2024
Merged
shenxianpeng added a commit that referenced this issue Mar 22, 2024
@shenxianpeng
reduction of notifications due to invalid tests #212
37ff1e0
@shenxianpeng shenxianpeng mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test CI issue by calling self test action cpp-linter/cpp-linter-action
2 participants
@shenxianpeng @2bndy5