Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilesList: add download all button #105

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

FilesList: add download all button #105

wants to merge 4 commits into from

Conversation

bqi343
Copy link
Member

@bqi343 bqi343 commented Jun 13, 2023

todos:

  • actually download the code
  • make this work for legacy IDE

@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 10:24pm

const fileData = snap.val();
console.log('fileData:');
console.log(fileData);
const code = 'TODO'; // extract from fileData?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: get code from YJS? idk how YJS works @thecodingwizard

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for legacy IDE, would want to iterate over editor-[lang] for each lang and obtain the code for each of them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For YJS:

If we wanted to be really fancy, we could even make the YJS server API handler return a ZIP file containing all of that users' files, so we only have to make one API request to get all the files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Firepad:

https://firepad.io/docs/#headless is probably what we want.

@bqi343 bqi343 linked an issue Jun 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants