Chef - Preserve returncode in stateful_shell (project-chip#19144)

cpagravel · Jun 15, 2022 · 4149978 · 4149978
1 parent bedb58a
commit 4149978
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/examples/chef/stateful_shell.py b/examples/chef/stateful_shell.py
@@ -92,8 +92,8 @@ def run_cmd(
             redirect = ""
 
         command_with_state = (
-            f"OLDPWD={self.env.get('OLDPWD', '')}; {cmd} {redirect};"
-            f" env -0 > {self.envfile_path}")
+            f"OLDPWD={self.env.get('OLDPWD', '')}; {cmd} {redirect}; RETCODE=$?;"
+            f" env -0 > {self.envfile_path}; exit $RETCODE")
         with subprocess.Popen(
             [command_with_state],
             env=self.env, cwd=self.cwd,
@@ -114,7 +114,9 @@ def run_cmd(
 
         if raise_on_returncode and returncode != 0:
             raise RuntimeError(
-                f"Error. Return code is not 0. It is: {returncode}")
+                "Error. Nonzero return code."
+                f"\nReturncode: {returncode}"
+                f"\nCmd: {cmd}")
 
         if return_cmd_output:
             with open(self.cmd_output_path, encoding="latin1") as f: