Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start over the application from CCA #120

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Conversation

CPatchane
Copy link
Contributor

@CPatchane CPatchane commented Nov 25, 2018

Restart all from a clean bootstrapped app from CCA

Closes #114 (thanks @ptbrowne)

@CPatchane CPatchane self-assigned this Nov 25, 2018
@CPatchane CPatchane force-pushed the start_over branch 15 times, most recently from 1eae50f to d75a4a7 Compare November 26, 2018 09:35
Copy link
Contributor

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@@ -0,0 +1,5 @@
const config = require('../babel.config')
const { createTransformer } = require('babel-jest')
module.exports = createTransformer({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createTransformer(config) ?

package.json Outdated
@@ -42,6 +42,7 @@
"stylint": "1.5.9"
},
"dependencies": {
"babel-core": "7.0.0-bridge.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a devDep ?

@CPatchane
Copy link
Contributor Author

I have to add this babel transformer usage in a troubleshooting section of CCA documentation since it could be necessary without specific reasons like here.

@CPatchane CPatchane merged commit fa1e2e7 into cozy:master Nov 26, 2018
@CPatchane CPatchane deleted the start_over branch November 26, 2018 10:47
gregorylegarec pushed a commit that referenced this pull request Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants