fix: Only serve approved slugs through HttpServer #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current HttpServer implementation set `source={html, baseUrl}` on the
iOS' WebView
By doing so, the WebView's history does not work anymore due to a bug
on `WKWebview` component
OnlyOffice (called from cozy-drive) relies on `window.history` in order
to handle navigation and check if it should display the back button, so
it does not work correctly on iOS when using HttpServer
To fix this, we temporarily disable HttpServer for cozy-drive on iOS
until we find a better solution
Relatted issue: react-native-webview/react-native-webview#2608
Current HttpServer implementation set `source={html, baseUrl}` on the
iOS' WebView
By doing so, the WebView's history does not work anymore due to a bug
on `WKWebview` component
This makes some iOS apps work incorrectly
In previous commits we set a blockList to prevent some slugs to be
served through HttpServer on iOS
But we found that there are still a lot of unknown features that may
not work
So we prefer to reverse the logic an only approve slugs that have been
test and proved to be working
Related issue: react-native-webview/react-native-webview#2608
Ldoppea
changed the title
Crash--
approved these changes
Dec 6, 2022
acezard
approved these changes
Dec 7, 2022
Ldoppea
added a commit
that referenced
this pull request
Aug 26, 2024
In iOS, we disabled HttpServer for all cozy-apps as the WebView API may behave differently The side effect is that we cannot open those app when offline as we cannot inject minimal code to make them work without network access So we want to enable HttpServer on those apps when we detect the app to be offline Related PR: #486
Ldoppea
added a commit
that referenced
this pull request
Aug 26, 2024
In iOS, we disabled HttpServer for all cozy-apps as the WebView API may behave differently The side effect is that we cannot open those app when offline as we cannot inject minimal code to make them work without network access So we want to enable HttpServer on those apps when we detect the app to be offline Related PR: #486
Ldoppea
added a commit
that referenced
this pull request
Sep 24, 2024
In iOS, we disabled HttpServer for all cozy-apps as the WebView API may behave differently The side effect is that we cannot open those app when offline as we cannot inject minimal code to make them work without network access So we want to enable HttpServer on those apps when we detect the app to be offline Related PR: #486
Ldoppea
added a commit
that referenced
this pull request
Sep 24, 2024
In iOS, we disabled HttpServer for all cozy-apps as the WebView API may behave differently The side effect is that we cannot open those app when offline as we cannot inject minimal code to make them work without network access So we want to enable HttpServer on those apps when we detect the app to be offline Related PR: #486
Ldoppea
added a commit
that referenced
this pull request
Sep 24, 2024
In iOS, we disabled HttpServer for all cozy-apps as the WebView API may behave differently The side effect is that we cannot open those app when offline as we cannot inject minimal code to make them work without network access So we want to enable HttpServer on those apps when we detect the app to be offline Related PR: #486
Ldoppea
added a commit
that referenced
this pull request
Sep 25, 2024
In iOS, we disabled HttpServer for all cozy-apps as the WebView API may behave differently The side effect is that we cannot open those app when offline as we cannot inject minimal code to make them work without network access So we want to enable HttpServer on those apps when we detect the app to be offline Related PR: #486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current HttpServer implementation set
source={html, baseUrl}on theiOS' WebView
By doing so, the WebView's history does not work anymore due to a bug
on
WKWebviewcomponentThis makes some iOS apps work incorrectly
In previous commits we set a blockList to prevent some slugs to be
served through HttpServer on iOS
But we found that there are still a lot of unknown features that may
not work
So we prefer to reverse the logic an only approve slugs that have been
test and proved to be working
Related issue: react-native-webview/react-native-webview#2608