Increase AsyncStorage read and write limits #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default Android cursor size is 2MB so we can not store entries larger than 2MB by default. But backup feature store quickly more than 2MB. There are two main possibilities : - AsyncStorage recommand to separate data in multiple entries and use multiGet and multiSet - increase sCursorWindowSize in MainApplication.java I try here the second way now which looks like the "easy quick fix". 50MB seems a reasonable value here. 1000 pictures in mediasToBackup ~ 330KiB See react-native-async-storage/async-storage#617 (comment) and https://react-native-async-storage.github.io/async-storage/docs/limits
After increasing read limit, let's increase write limit using the AsyncStorage recommended way.
zatteo
force-pushed
the
fix/backup-local-storage
branch
from
40c58d3
to
7df333c
Compare
Crash--
approved these changes
Nov 13, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix backup issues resulting in "Backup config not initialized" errors
Read limit per entry : 2MB to 50MB
Write limit per whole app: 6MB to 100MB