feat: Implement FlagshipLink #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
force-pushed
the
feat/make_replication_work
branch
from
adf578d
to
1ef1168
Compare
Ldoppea
force-pushed
the
feat/add_flagshiplink
branch
from
33d9442
to
1049c10
Compare
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Jul 30, 2024
In previous commits we configured the application's cozy-client to use CozyPouchLink This link is configured for all react-native side queries, but not for cozy-app queries as they are served inside of WebViews and use a different cozy-client instance We want cozy-apps to benefits from the CozyPouchLink by redirecting their queries to the react-native side using the new FlagshipLink interface With this interface, all cozy-apps queries can be redirected to the react-native side using cozy-intent/post-me In order to intercept them, then we should declare `FlagshipLinkRequest()` method `localMethods` Related PR: cozy/cozy-client#1505
paultranvan
reviewed
Aug 13, 2024
| 'Using options.client is deprecated, prefer options.stackClient' | ||
| ) | ||
| } | ||
| this.stackClient = stackClient || client |
There was a problem hiding this comment.
Why do we have a stackClient here?
Ldoppea
force-pushed
the
feat/make_replication_work
branch
from
1ef1168
to
cf64f7a
Compare
Ldoppea
force-pushed
the
feat/add_flagshiplink
branch
from
1049c10
to
b82c1a6
Compare
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Aug 26, 2024
In previous commits we configured the application's cozy-client to use CozyPouchLink This link is configured for all react-native side queries, but not for cozy-app queries as they are served inside of WebViews and use a different cozy-client instance We want cozy-apps to benefits from the CozyPouchLink by redirecting their queries to the react-native side using the new FlagshipLink interface With this interface, all cozy-apps queries can be redirected to the react-native side using cozy-intent/post-me In order to intercept them, then we should declare `FlagshipLinkRequest()` method `localMethods` Related PR: cozy/cozy-client#1505
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Aug 26, 2024
In previous commits we configured the application's cozy-client to use CozyPouchLink This link is configured for all react-native side queries, but not for cozy-app queries as they are served inside of WebViews and use a different cozy-client instance We want cozy-apps to benefits from the CozyPouchLink by redirecting their queries to the react-native side using the new FlagshipLink interface With this interface, all cozy-apps queries can be redirected to the react-native side using cozy-intent/post-me In order to intercept them, then we should declare `FlagshipLinkRequest()` method `localMethods` Related PR: cozy/cozy-client#1505
Ldoppea
added a commit
that referenced
this pull request
Sep 4, 2024
Ldoppea
force-pushed
the
feat/make_replication_work
branch
from
cf64f7a
to
421c2da
Compare
Base automatically changed from
feat/make_replication_work
to
feat/meta_offline
September 9, 2024 10:30
`cozy-intent` has been upgraded to `2.23.0` to retrieve `flagshipLinkRequest` new intent Related PR: cozy/cozy-libs#2562
When hosted in the Flagship app, we want the cozy-apps to be able to forward their queries to the native code This will allow the native code to have control on the data lifecycle and chose between the cozy-stack or a local Pouch database as the source for executing the query For now we use cozy-intent in order to communicate through post messages as it is the fastest implementation possible but this may change in the future if we encounter performances issues (i.e. using a local HTTP server)
Ldoppea
force-pushed
the
feat/add_flagshiplink
branch
from
b82c1a6
to
c8ab4c7
Compare
Ldoppea
added a commit
that referenced
this pull request
Sep 9, 2024
Ldoppea
added a commit
that referenced
this pull request
Sep 9, 2024
Ldoppea
added a commit
that referenced
this pull request
Sep 9, 2024
Ldoppea
added a commit
that referenced
this pull request
Sep 19, 2024
Ldoppea
added a commit
that referenced
this pull request
Sep 19, 2024
Ldoppea
added a commit
that referenced
this pull request
Sep 24, 2024
Ldoppea
added a commit
that referenced
this pull request
Sep 24, 2024
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Sep 24, 2024
In previous commits we configured the application's cozy-client to use CozyPouchLink This link is configured for all react-native side queries, but not for cozy-app queries as they are served inside of WebViews and use a different cozy-client instance We want cozy-apps to benefits from the CozyPouchLink by redirecting their queries to the react-native side using the new FlagshipLink interface With this interface, all cozy-apps queries can be redirected to the react-native side using cozy-intent/post-me In order to intercept them, then we should declare `FlagshipLinkRequest()` method `localMethods` Related PR: cozy/cozy-client#1505
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Sep 24, 2024
In previous commits we configured the application's cozy-client to use CozyPouchLink This link is configured for all react-native side queries, but not for cozy-app queries as they are served inside of WebViews and use a different cozy-client instance We want cozy-apps to benefits from the CozyPouchLink by redirecting their queries to the react-native side using the new FlagshipLink interface With this interface, all cozy-apps queries can be redirected to the react-native side using cozy-intent/post-me In order to intercept them, then we should declare `FlagshipLinkRequest()` method `localMethods` Related PR: cozy/cozy-client#1505
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Sep 25, 2024
In previous commits we configured the application's cozy-client to use CozyPouchLink This link is configured for all react-native side queries, but not for cozy-app queries as they are served inside of WebViews and use a different cozy-client instance We want cozy-apps to benefits from the CozyPouchLink by redirecting their queries to the react-native side using the new FlagshipLink interface With this interface, all cozy-apps queries can be redirected to the react-native side using cozy-intent/post-me In order to intercept them, then we should declare `FlagshipLinkRequest()` method `localMethods` Related PR: cozy/cozy-client#1505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hosted in the Flagship app, we want the cozy-apps to be able to forward their queries to the native code
This will allow the native code to have control on the data lifecycle and chose between the cozy-stack or a local Pouch database as the source for executing the query
For now we use cozy-intent in order to communicate through post messages as it is the fastest implementation possible but this may change in the future if we encounter performances issues (i.e. using a local HTTP server)
TODO:
Related PRs: