proxy: fix case order in a type switch #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type switch executes its clauses sequentially until the first match. The `*tcpmux.Stream` type implements `net.Conn`, so if `net.Conn` goes before `*tcpmux.Stream` case, it will catch `*tcpmux.Stream` values and will never let `case `*tcpmux.Stream` to execute. The solution is simple, move specific type case before the interface it implements. Found using gocritic linter, `caseOrder` checker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type switch executes its clauses sequentially until the first match.
The
*tcpmux.Streamtype implementsnet.Conn, so ifnet.Conngoesbefore
*tcpmux.Streamcase, it will catch*tcpmux.Streamvalues and willnever let
case*tcpmux.Stream` to execute. The solution is simple, movespecific type case before the interface it implements.
Found using gocritic linter,
caseOrderchecker.