Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check if its not due yet #24

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Don't check if its not due yet #24

merged 1 commit into from
Sep 19, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Sep 11, 2023

This PR lets watchtower to ignore the check of some conditional orders for certain conditions.

It will use the persisted result from last poll, where we can see if:

  • TRY_AT_EPOCH: skip the check if the epoch is not due yet
  • TRY_ON_BLOCK: skip the check if the block number is not due yet

Fixes #8

@anxolin anxolin marked this pull request as ready for review September 11, 2023 14:18
@mfw78 mfw78 linked an issue Sep 18, 2023 that may be closed by this pull request
@anxolin anxolin merged commit 358df8b into main Sep 19, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
@alfetopito alfetopito deleted the dont-check-if-not-due branch September 19, 2023 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Allow specific order implementations to signal the next checkTime
3 participants